chore: fix outdated plugin structure mentions - #3012
Merged
JasonYeMSFT (JasonYeMSFT) merged 3 commits intoAug 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates remaining references to the legacy plugin/skills/... layout to the newer multi-plugin layout (plugins/{plugin}/skills/...), aligns token/frontmatter dashboard fixtures with the new paths, adjusts the integration workflow’s environment wiring for usage uploads, and updates the dashboard’s Skills view link/path handling for plugin-scoped output paths.
Changes:
- Replace documentation/test fixtures that referenced
plugin/skills/...withplugins/{plugin}/skills/.... - Update the integration workflow to derive
SKILLfrom the (potentially path-like)matrix.skillinput before uploading token/tool usage rows. - Update the dashboard Skills view path normalization to map
output/<plugin>/skills/.../SKILL.mdback toplugins/<plugin>/skills/.../SKILL.md.
Show a summary per file
| File | Description |
|---|---|
| tests/AGENTS.md | Update guidance to reference plugins/{plugin}/skills/... paths. |
| scripts/src/tokens/tests/utils.test.ts | Adjust token-limit tests to use new plugin-scoped skill paths. |
| scripts/src/tokens/tests/types.test.ts | Update pattern-matching test to reflect new plugin-scoped paths. |
| scripts/src/shared/skill-helper.ts | Update documentation comments to describe plugins/<plugin>/skills/... layout. |
| scripts/src/dashboard/tests/collectors/references.test.ts | Update dashboard reference collector tests to new paths. |
| scripts/src/dashboard/tests/collectors/frontmatter.test.ts | Update dashboard frontmatter collector tests to new paths. |
| evals/azure-skills/azure-enterprise-infra-planner/eval.yaml | Remove outdated comment referencing the old plugin/skills/... path. |
| dashboard/src/skills/App.tsx | Update Skills view path normalization/filtering for output/<plugin>/skills/... and plugins/<plugin>/skills/.... |
| dashboard/src/skills/tests/skillLink.test.ts | Update tests to validate the new path mapping behavior. |
| .github/workflows/test-all-integration.yml | Ensure SKILL is derived from matrix.skill basename before uploading token/tool usage. |
| .github/skills/skill-reviewer/SKILL.md | Update skill-reviewer documentation references to the new plugin layout. |
| .github/skills/skill-reviewer/references/review-checklist.md | Update checklist header to reference plugins/{plugin}/skills/. |
| .github/skills/skill-authoring/references/token-budgets.md | Update token-check example command to use plugins/{plugin}/skills/.... |
| .github/skills/sensei/SKILL.md | Update sensei instructions/constraints to the new plugin layout. |
| .github/skills/investigate-integration-test/SKILL.md | Update investigation guidance to reference plugins/*/skills. |
| .github/ISSUE_TEMPLATE/skill_extension_request.yml | Update issue template description to reference plugins/*/skills/. |
| .github/instructions/skill-files.instructions.md | Update applyTo glob to target plugins/*/skills/**/SKILL.md. |
| .github/copilot-instructions.md | Update “create the skill directory” instruction to the new plugin layout. |
Review details
Suppressed comments (1)
dashboard/src/skills/App.tsx:86
isPluginSkillPathuses unanchored regexes without requiring a trailing slash, so it can match unintended substrings (e.g.foo/output/azure-skills/skillsX). Since this predicate gates which items appear in the Skills view, it’s safer to anchor the match and require the.../skills/directory boundary (and totrim()likeskillMdUrldoes).
function isPluginSkillPath(pathValue: string): boolean {
const normalized = pathValue.replace(/\\/g, "/");
return /output\/[a-zA-Z-]+\/skills/.test(normalized) || /plugins\/[a-zA-Z-]+\/skills/.test(normalized);
}
- Files reviewed: 18/18 changed files
- Comments generated: 2
- Review effort level: Lite
Tom Meschter (tmeschter)
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the remaining outdated mentions of the old plugin folder structure to use the new one. Fixed the script in the integration test workflow to upload the tool/token usage rows with correct PartitionKey. Fixed the way
Skillview in the integration dashboard to properly load skills for a plugin.Checklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:integration -- <skill>ornpm run test:vally -- --skill <skill>)Related Issues